Skip to content

feat(markdown): support directives, add callout and tabs - #2601

Merged
spike-rabbit merged 6 commits into
mainfrom
feat/markdown/directives
Aug 27, 2026
Merged

feat(markdown): support directives, add callout and tabs#2601
spike-rabbit merged 6 commits into
mainfrom
feat/markdown/directives

Conversation

@dr-itz

@dr-itz dr-itz commented Aug 23, 2026

Copy link
Copy Markdown
Member

@dr-itz
dr-itz force-pushed the feat/markdown/directives branch 2 times, most recently from 595be25 to 9db19cf Compare August 23, 2026 21:06

@kfenner kfenner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kfenner

kfenner commented Aug 25, 2026

Copy link
Copy Markdown
Member

@dr-itz Super cool, thank you 🙏 🎉

IMHO we can merge as-is. @spike-rabbit @Killusions any inputs?

@dr-itz
dr-itz force-pushed the feat/markdown/directives branch from 8cd8dd7 to dda647c Compare August 25, 2026 12:35
@dr-itz
dr-itz marked this pull request as ready for review August 25, 2026 20:02
@dr-itz
dr-itz requested review from a team as code owners August 25, 2026 20:02
Comment thread projects/element-ng/markdown/directives/callout/si-markdown-callout.component.ts Outdated
Comment thread projects/element-ng/markdown/directives/tabs/si-markdown-tabset.component.ts Outdated
@dr-itz
dr-itz force-pushed the feat/markdown/directives branch from dda647c to 5968b81 Compare August 26, 2026 22:01
@dr-itz
dr-itz requested a review from spike-rabbit August 26, 2026 22:06

@spike-rabbit spike-rabbit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@spike-rabbit
spike-rabbit added this pull request to the merge queue Aug 27, 2026
Merged via the queue into main with commit 09b725e Aug 27, 2026
15 checks passed
@spike-rabbit
spike-rabbit deleted the feat/markdown/directives branch August 27, 2026 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants